Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin moment dependency to fix security vulnerability #10

Merged
merged 1 commit into from Sep 19, 2017
Merged

Unpin moment dependency to fix security vulnerability #10

merged 1 commit into from Sep 19, 2017

Conversation

avindra
Copy link
Contributor

@avindra avindra commented Sep 19, 2017 •
edited

Details of the vulnerability are described here:

This also:

  • adds stable node to unit testing matrix

Would like to get a release cut for this, and to have blue-button updated as well 馃檹

Filed upstream issue amida-tech/blue-button#253 as well

@avindra
Unlock moment to fix security vulnerability
e0bcaed 
 * also adds stable node to unit testing matrix
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 84.847% when pulling e0bcaed on avindra:fix-security-issues into dcbb1db on amida-tech:master.

@avindra avindra mentioned this pull request Sep 19, 2017
Closed
@avindra
Copy link
Contributor Author

avindra commented Sep 19, 2017

0.10 is failing, but imho, that should be dropped in favor of testing only active LTS versions of node.

@jsachs jsachs merged commit 19e78cf into amida-tech:master Sep 19, 2017
@avindra avindra deleted the fix-security-issues branch September 19, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avindra @coveralls @jsachs