Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insurance bj #21

Closed
wants to merge 11 commits into from
Closed

Insurance bj #21

wants to merge 11 commits into from

Conversation

byshiny
Copy link

@byshiny byshiny commented Jul 29, 2014

  • Added various hard code modifications for claims and insurance.
  • Added simple test-cms-usage test file, which is a mirror of ccda except some changes for cms.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.79%) when pulling e3eb0d0 on insurance-bj into 58cb33a on 1.1.0-beta.

@au2
Copy link
Member

au2 commented Jul 31, 2014

  1. I put a pull request now which removes the dependance to blue-button so you do not need changes for generateSchema call (it does not exist anymore).
  2. I do not understand why we are using every in Object.keys(allSections).every(function(secName). First the return value of every is not handled, second if every returns early (with false value) the other sections are not tested. So essentially you disabled a test if cms keys come before ccd keys. I would use forEach and just put everything inside "if" so that test is still functional for ccd sections.

@byshiny
Copy link
Author

byshiny commented Jul 31, 2014

Ok I'll change that.

@byshiny byshiny closed this Aug 11, 2014
@kachok kachok deleted the insurance-bj branch January 29, 2015 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants