Fix RXNorm spelling suggestions loop

amida-tech · Sep 21, 2015 · 1042e1c · 1042e1c
1 parent 5e5caf5
commit 1042e1c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/controllers/rxnorm.js b/lib/controllers/rxnorm.js
@@ -35,12 +35,18 @@ router.post("/spelling", function (req, res, next) {
         // rxnorm lib returns JSON for queryRxNormSpelling
         var result = JSON.parse(rawResult);
         // if no results are found, we should return an object rather than null
-        if (result.suggestionGroup.suggestionList === null) {
+        if (typeof result.suggestionGroup.suggestionList === "undefined" || result.suggestionGroup.suggestionList === null) {
             result.suggestionGroup.suggestionList = {
                 suggestion: []
             };
         }
 
+        // remove results identical to the query
+        // (prevents looping suggestions in the UI)
+        result.suggestionGroup.suggestionList.suggestion = result.suggestionGroup.suggestionList.suggestion.filter(function (suggestion) {
+            return suggestion.toLowerCase().trim() !== medname.toLowerCase().trim();
+        });
+
         // basic object response
         // just return data as it's provided to us
         res.send({

diff --git a/test/rxnorm/query_spelling_test.js b/test/rxnorm/query_spelling_test.js
@@ -41,5 +41,18 @@ describe("RXNorm", function () {
                 expect(response.body.result.suggestionGroup.suggestionList.suggestion.length).to.be.above(0);
             });
         });
+
+        it("ignores suggestions with the name equal to the queried name", function () {
+            return query({
+                medname: "multivitamins"
+            }).then(function (response) {
+                expect(response).to.be.an.rxnorm.spellingSuccess;
+                console.log(response.body.result.suggestionGroup.suggestionList);
+                expect(response.body.result.suggestionGroup.suggestionList.suggestion.length).to.be.above(0);
+                expect(response.body.result.suggestionGroup.suggestionList.suggestion).to.not.include("multivitamins");
+                expect(response.body.result.suggestionGroup.suggestionList.suggestion).to.not.include("Multivitamins");
+                expect(response.body.result.suggestionGroup.suggestionList.suggestion).to.not.include("MULTIVITAMINS");
+            });
+        });
     });
 });