"Send Command" shell whitespace fix #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what branch to merge this too - I can rebase off devel if need be, or I can alter the PR to merge against master. |
|
thanks please rebase off develop. It looks good but I still need to do full regression testing to make sure it won't break existing functionality of scripts in production. I have already frozen all code for an upcoming release, so I will try to get it into the release after next. |
…tems where bash is in a different location
SoarinFerret
force-pushed
the
send-command-shell-fix
branch
from
e07d6f6
to
751b50e
Compare
|
This has been rebased on develop - let me know if you need anything else! |
|
works great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to use
/usr/bin/env bashas the custom shell inSend Command, no output is returned. This is because gocmd wants the first parameter to be the executable, with everything else being arguments afterwards.This simple 2 line patch fixes aforementioned issue. This is useful on systems like NixOS, where bash is not in an easily identifiable location, so you have to use the above syntax.
I do not know if this code would be useful in the other cases in the if statement - if so, I could update the patch to include those.
Thanks in advance!