Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VigilantAction + unit tests #66

Merged
merged 3 commits into from Nov 21, 2017
Merged

Added VigilantAction + unit tests #66

merged 3 commits into from Nov 21, 2017

Conversation

amihaiemil
Copy link
Owner

Fixes #65

Also refactored the exception handling from GithubAction and GithubSteps.
Now a GithubAction is wrapped inside VigilantAction, which catches exceptions and opens a Github issue in comdor's repository.

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage decreased (-0.08%) to 74.476% when pulling 5db5364 on 65 into 545a88b on master.

@coveralls
Copy link

coveralls commented Nov 21, 2017

Coverage Status

Coverage decreased (-0.03%) to 74.525% when pulling d0bb2d5 on 65 into 545a88b on master.

@amihaiemil
Copy link
Owner Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Nov 21, 2017

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit d0bb2d5 into master Nov 21, 2017
@rultor
Copy link
Collaborator

rultor commented Nov 21, 2017

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants