Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SslHttpClient.java:50-52: Using the provided... #100

Closed
0pdd opened this issue May 8, 2018 · 20 comments
Closed

SslHttpClient.java:50-52: Using the provided... #100

0pdd opened this issue May 8, 2018 · 20 comments
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented May 8, 2018

The puzzle 67-80672d59 from #67 has to be resolved:

* @todo #67:30min Using the provided certificates,
* register the http/https protocols, similar to how "unix" is
* registered in UnixHttpClient.

The puzzle was created by amihaiemil on 08-May-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

@amihaiemil/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

@0pdd/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

Job #100 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 11, 2018

The job #100 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@amihaiemil
Copy link
Owner

@llorllale This is a rather complex task. The big outline is that we need to first read the contents of the certificates, then use them to create objects of type KeyStore and such (from the JDK), which will go to some Factory from Apache -- that's how the guys from Spotify did it here but if you have a better idea, feel free to say it. This, of course, can be a research task as well :D

@llorllale
Copy link
Contributor

llorllale commented May 16, 2018

@amihaiemil this here...

    /**
     * Ctor.
     * @param certs Path to the folder containing the following certificates:
     *  ca.pem, cert.pem and key.pem.
     */
    SslHttpClient(final Path certs, final char[] passwd) {

Is cert.pem the docker server's public key?

Some references:

@llorllale
Copy link
Contributor

@0crat waiting

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

@0crat waiting (here)

@llorllale The impediment for #100 was registered successfully by @llorllale/z

@amihaiemil
Copy link
Owner

@llorllale

Is cert.pem the docker server's public key?

Yes, I think so, param Path certs points to a folder containing the following certificates: ca.pem, cert.pem and key.pem. key is the private key and I assume cert is the public one. These 3 are created when you create a remote docker host using dockermachine.

I assume you spent the time researching (or more, let me know if so). So just edit the puzzle with the resources that you found :D

@llorllale
Copy link
Contributor

@amihaiemil is this supposed to be two-way or one-way tls?

@amihaiemil
Copy link
Owner

@llorllale two-way, that's my understanding, since we don't have other authentication mechanism between the docker client and the remote docker host.

@llorllale
Copy link
Contributor

@amihaiemil and is ca.pem the server's public key? I'm confused because "ca" sounds like "certificate authority", which would definitely not be docker.

@amihaiemil
Copy link
Owner

amihaiemil commented May 23, 2018

@llorllale yes, I think it is the server's public key as well.

ca.pem - server public key -- the server's public key issues by the CA, right? I think that's why the name is ca.pem
cert.pem - client certificate
key.pem - client key

@llorllale
Copy link
Contributor

@0crat waiting for review/merge on #120

@0crat
Copy link
Collaborator

0crat commented May 24, 2018

@0crat waiting for review/merge on #120 (here)

@llorllale Job #100 is already on hold

@amihaiemil
Copy link
Owner

@0crat boost 6x

@0crat
Copy link
Collaborator

0crat commented May 25, 2018

@0crat boost 6x (here)

@amihaiemil Boost 6x was set for #100

@0crat
Copy link
Collaborator

0crat commented May 25, 2018

Boosting tasks is against our principles, see §15: -10 point(s) just awarded to @amihaiemil/z

llorllale added a commit to llorllale/docker-java-api that referenced this issue May 28, 2018
As per request in PR:
* made RemoteDocker package-private
@0crat
Copy link
Collaborator

0crat commented May 29, 2018

Order was finished: +90 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 29, 2018

The job #100 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

4 participants