New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image.run(...) #127
Comments
Job #127 is now in scope, role is |
Bug was reported, see §29: +15 point(s) just awarded to @amihaiemil/z |
@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
@0crat wait while I try to understand something... |
@llorllale The impediment for #127 was registered successfully by @llorllale/z |
@amihaiemil seems like the JSONs holding the image's metadata don't have a dedicated "name" field. The closest thing I see that we could use is "RepoTags": [
"example:1.0",
"example:latest",
"example:stable"
] Is the first half of those values always the same? |
@llorllale Yes, I also noticed that, but we add the Also, the name of the image is in its URI, as the last segment (but better take it from the Json). Is this what you asked? :D |
Well, yes, but there's no guarantee that it'll be constant. I just tested:
And resulting inspection for "RepoTags": [
"alpine:latest",
"docker-java-api:latest"
] |
@llorllale I see, but you don't really need that, do you? Since the name is in the Json (we append it manually when pulling the image) and URI anyay. Or you mean something else? |
@amihaiemil as far as I can see, there is no |
@llorllale Yes, exactly, and since RtImage has the name of the Image, it can somehow use RtContainers and create and start a container using its name. RtImage will get the Containers instance from the encapsulated Docker instance -- I also want to implement this: any object of the API should have a method to return its parent Docker instance. So Image.run() would look something like this (pseudocode): final Container ctn = this.docker.containers.create(this.name);
ctn.start();
return ctn; Do you like the idea? Maybe you can start by passing the Docker instance to RtImage and have public method |
Sure. Now back to my original question.
As I've shown, |
@llorllale Yes, I think the URI is the safest, go with that. |
@llorllale Job #127 is already on hold |
@0crat boost x6 |
@amihaiemil Argument "x6" doesn't match regex |
@0crat boost 6x |
There is an unrecoverable failure on my side. Please, submit it here:
|
@0crat boost 6x |
@amihaiemil Boost 6x was set for #127 |
Boosting tasks is against our principles, see §15: -10 point(s) just awarded to @amihaiemil/z |
As per PR review: Fixed assertion in RtImageTestCase.runsItselfOk()
There is an unrecoverable failure on my side. Please, submit it here:
0.22.22: CID: 1720734113, Type: "Close job", Author: "amihaiemil" |
@amihaiemil can this be taken out of scope? |
@0crat out |
Order was finished: +30 point(s) just awarded to @llorllale/z |
@amihaiemil The job #127 is now out of scope |
Image should have the
run
option, and return the created Container. This will be the equivalent of thedocker run IMAGE
command.The text was updated successfully, but these errors were encountered: