Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show all containers, not only running ones #161

Closed
wem opened this issue Oct 23, 2018 · 17 comments
Closed

Option to show all containers, not only running ones #161

wem opened this issue Oct 23, 2018 · 17 comments
Assignees
Labels
30min @amihaiemil bug Something isn't working

Comments

@wem
Copy link

wem commented Oct 23, 2018

First, very simple, small lib!
It would be nice to make it possible to query for all containers, not only the running one (with the "all" query param)

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

@amihaiemil/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

@wem/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@amihaiemil
Copy link
Owner

amihaiemil commented Oct 23, 2018

@wem thank you! please give it your Star if you like it, it helps a lot.

I will take care of it today. Do you think the method Containers.all() would be ok? So:

Iterator<Container> :: Containers.iterator() remains as now, returns all running containers and Iterator<Container> :: Containers.all() will return all of them, not only the running ones.

@amihaiemil amihaiemil self-assigned this Oct 23, 2018
@amihaiemil amihaiemil added bug Something isn't working @amihaiemil 30min labels Oct 23, 2018
@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Thanks for your contribution, @wem/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

The job #161 assigned to @amihaiemil/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Job gh:amihaiemil/docker-java-api#161 already assigned to @amihaiemil, can't assign to @amihaiemil

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @amihaiemil/z

@wem
Copy link
Author

wem commented Oct 23, 2018

@amihaiemil Container.all() would be a nice solution!
I will think about to join this project

@amihaiemil
Copy link
Owner

@wem thanks, I'm on it just now :)

@amihaiemil
Copy link
Owner

@rultor let's release it, tag is 0.0.4

@rultor
Copy link
Collaborator

rultor commented Oct 23, 2018

@rultor let's release it, tag is 0.0.4

@amihaiemil OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 23, 2018

@rultor let's release it, tag is 0.0.4

@amihaiemil Done! FYI, the full log is here (took me 4min)

@amihaiemil
Copy link
Owner

@wem Done, version 0.0.4 is released, you should already be able to pull it with maven (see README for updated coordinates).

Could you please close this Issue? I think the PM will complain if I do it :(

@wem
Copy link
Author

wem commented Oct 23, 2018

Works like a charm. Thx!

@wem wem closed this as completed Oct 23, 2018
@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Job was finished in 9 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

The job #161 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Oct 23, 2018

Order was finished: +35 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
30min @amihaiemil bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants