Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteDocker.java:39-41: Implement integration tests for... #178

Closed
0pdd opened this issue Nov 4, 2018 · 19 comments
Closed

RemoteDocker.java:39-41: Implement integration tests for... #178

0pdd opened this issue Nov 4, 2018 · 19 comments
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Nov 4, 2018

The puzzle 68-39eec482 from #68 has to be resolved:

* @checkstyle ParameterNumber (150 lines)
* @todo #68:30min Implement integration tests for RemoteDocker. We have to
* figure out how to create a remote Docker host and connect to it from Travis.

The puzzle was created by rultor on 23-May-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Nov 4, 2018

@amihaiemil please pay attention to this new issue.

@0pdd 0pdd added bug Something isn't working pdd labels Nov 4, 2018
@0crat
Copy link
Collaborator

0crat commented Nov 4, 2018

@amihaiemil/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Nov 4, 2018

Job #178 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Nov 4, 2018

The job #178 assigned to @llorllale/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Nov 9, 2018

@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@llorllale
Copy link
Contributor

@0crat refuse because I'm leaving this one to @amihaiemil.

I see one possible way forward that does not involve hosting a docker service in the cloud: running the docker-in-docker image, and running our tests in another container linked to the first.

@0crat
Copy link
Collaborator

0crat commented Nov 13, 2018

@0crat refuse because I'm leaving this one to @amihaiemil. I see one possible way forward tha... (here)

@llorllale The user @llorllale/z resigned from #178, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Nov 13, 2018

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @llorllale/z

@amihaiemil
Copy link
Owner

@llorllale thank you for your idea. I will have a look over the weekend and also over your PRs (too busy week now, sorry).

@0crat
Copy link
Collaborator

0crat commented Dec 3, 2018

The job #178 assigned to @bkuzmic/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@amihaiemil
Copy link
Owner

@0crat out

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

@0crat out (here)

@amihaiemil GitHub issue is still open, won't close

@bkuzmic
Copy link
Contributor

bkuzmic commented Dec 4, 2018

To continue with docker-in-docker idea, there are couple of options:

  1. If we only want to run IT cases for remote Docker manually or with Travis, then before running maven build, one can run:

    docker run -it --privileged -p 12375:2375 docker:dind
    This will expose remote Docker server on local port: 12375 and be accessible using: http://127.0.0.1:12375/

  2. Using same docker image, but running through JUnit using: TestContainers-Java

@amihaiemil
Copy link
Owner

@bkuzmic I see, thank you for your input. It's enough for now, I'll have a look later. I'll remove the puzzle so this task is closed :D

amihaiemil added a commit that referenced this issue Dec 4, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 4, 2018

The puzzle 68-39eec482 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@49da8b6e-a0bd-48c7-a0cd-3edbad03b45d, thread: AsyncProc-5
com.jcabi.xml.StrictXML[124] java.lang.IllegalArgumentException: 1 error(s) in XML document: -1:-1: Duplicate unique value [gh:amihaiemil/docker-java-api#178] declared for identity constraint of element "verbosity".

0.38.6: CID: 10ae4b62-b189-48e7-9d6e-8661c99aa370, Type: "Close job"

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

Job was finished in 18 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

The job #178 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

Order was finished: +35 point(s) just awarded to @bkuzmic/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

5 participants