RtContainersTestCase.java:33-35: Write unit tests for all...

[0pdd]

The puzzle 26-a8980bc9 from #26 has to be resolved:

docker-java-api/src/test/java/com/amihaiemil/docker/RtContainersTestCase.java

Lines 33 to 35 in f5a14a6

	* @todo #26:30min Write unit tests for all the methods of RtContainers.
	* AssertRequest should be passed in the ctor, with the right expected
	* response and predicates.

The puzzle was created by amihaiemil on 13-Mar-18.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

[0crat]

Job #47 is now in scope, role is DEV

[0crat]

The job #47 assigned to @llorllale/z, here is why. The budget is 30 minutes, see §4. Please, read §8 and §9. If the task is not clear, read this and this.

[llorllale]

@amihaiemil what's the url?

@param container Json config as specified in the API's docs.

Would be nice if we added to the javadocs:

@see <a href="api_doc_url">Docker API</a>

[amihaiemil]

@llorllale right; this is the URL: https://docs.docker.com/engine/api/v1.30/#operation/ContainerCreate

The API docs is for 1.30; I guess it won't change that much in future versions. Besides, whoever knows how to read it will also know to check the right version they need :)

[llorllale]

@amihaiemil I'm think about creating Response that implements HttpResponse in order to support tests. WDYT?

The idea is to provide an easy way to specify an HttpResponse to the AssertRequest ctor.

eg.:

new AssertRequest(
    new Response(HttpStatus.SC_OK, "json_payload"),
    conditions...
)

[llorllale]

@amihaiemil here's an example of what this might all look like:

    /**
     * Should create container if request valid and no error is returned from
     * the Docker API.
     * 
     * @throws Exception unexpected
     */
    @Test
    public void createContainerFromImageName() throws Exception {
        MatcherAssert.assertThat(
            new RtContainers(
                new AssertRequest(
                    new Response(
                        HttpStatus.SC_CREATED, "{ \"Id\": \"df2419f4\" }"
                    ),
                    new Condition(
                        "The 'Content-Type' header must be set.",
                        req -> req.getHeaders("Content-Type").length > 0
                    ),
                    new Condition(
                        "Content-Type must be 'application/json'.",
                        // @checkstyle LineLength (1 line)
                        req -> "application/json".equals(req.getHeaders("Content-Type")[0].getValue())
                    ),
                    new Condition(
                        "Resource path must be /containers/create",
                        // @checkstyle LineLength (1 line)
                        req -> req.getRequestLine().getUri().endsWith("/containers/create")
                    )
                ), URI.create("http://localhost/test")
            ).create("some_image"),
            Matchers.notNullValue()
        );
    }

[amihaiemil]

@llorllale Yeah, seems like a good idea :)

[0pdd]

The puzzle 26-a8980bc9 has disappeared from the source code, that's why I closed this issue.

[0pdd]

@0pdd 2 puzzles #53, #54 are still not solved.

[0crat]

Order was finished: +30 points just awarded to @llorllale/z

[0crat]

The job #47 is now out of scope

[0pdd]

@0pdd the puzzle #54 is still not solved; solved: #53.

[0pdd]

@0pdd all 2 puzzles are solved here: #53, #54.