Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images.save + ListedImages unit test #155

Merged
merged 1 commit into from Aug 26, 2018
Merged

Images.save + ListedImages unit test #155

merged 1 commit into from Aug 26, 2018

Conversation

amihaiemil
Copy link
Owner

PR for #152

Added Images.save(), unit test for ListedImages.iterate() and puzzles

@0crat
Copy link
Collaborator

0crat commented Aug 26, 2018

Job #155 is now in scope, role is REV

@coveralls
Copy link

Pull Request Test Coverage Report for Build 292

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 80.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtImages.java 0 13 0.0%
Totals Coverage Status
Change from base Build 290: -2.3%
Covered Lines: 385
Relevant Lines: 476

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 292

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.3%) to 80.882%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtImages.java 0 13 0.0%
Totals Coverage Status
Change from base Build 290: -2.3%
Covered Lines: 385
Relevant Lines: 476

💛 - Coveralls

@amihaiemil
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Aug 26, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e2ec92f into master Aug 26, 2018
@rultor
Copy link
Collaborator

rultor commented Aug 26, 2018

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 3min)

@amihaiemil amihaiemil deleted the 152 branch August 26, 2018 08:44
@0crat
Copy link
Collaborator

0crat commented Aug 26, 2018

Job gh:amihaiemil/docker-java-api#155 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Aug 26, 2018

The job #155 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants