Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images.importFromTar() :: Images #292

Merged
merged 2 commits into from Jan 14, 2019
Merged

Images.importFromTar() :: Images #292

merged 2 commits into from Jan 14, 2019

Conversation

amihaiemil
Copy link
Owner

PR for #277
The method is now returning this, since Images will always iterate over the existing images (this means also the newly imported ones will be iterated).

@0crat 0crat added the scope label Jan 14, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Job #292 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Jan 14, 2019

Pull Request Test Coverage Report for Build 516

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.183%

Totals Coverage Status
Change from base Build 513: 0.0%
Covered Lines: 817
Relevant Lines: 896

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

This pull request #292 is assigned to @bkuzmic/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@bkuzmic
Copy link
Contributor

bkuzmic commented Jan 14, 2019

@amihaiemil Looks good to me! I guess you don't need my approval of changes, right?! :)

@bkuzmic
Copy link
Contributor

bkuzmic commented Jan 14, 2019

@rultor merge it.

@rultor
Copy link
Collaborator

rultor commented Jan 14, 2019

@rultor merge it.

@bkuzmic Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Jan 14, 2019

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a997d78 into master Jan 14, 2019
@amihaiemil amihaiemil deleted the 277 branch January 14, 2019 13:19
@rultor
Copy link
Collaborator

rultor commented Jan 14, 2019

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 2min)

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Jan 14, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

The job #292 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Order was finished: +20 point(s) just awarded to @bkuzmic/z

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Job gh:amihaiemil/docker-java-api#292 doesn't exist in WBS, can't create order

@0crat
Copy link
Collaborator

0crat commented Jan 14, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants