Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RtContainers, RtContainer started + puzzles #43

Merged
merged 2 commits into from
Mar 13, 2018
Merged

RtContainers, RtContainer started + puzzles #43

merged 2 commits into from
Mar 13, 2018

Conversation

amihaiemil
Copy link
Owner

Pr for #28

Started implementation of RtContainers and RtContainer.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 63

  • 6 of 38 (15.79%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-25.8%) to 46.25%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtContainer.java 6 7 85.71%
src/main/java/com/amihaiemil/docker/RtDocker.java 0 2 0.0%
src/main/java/com/amihaiemil/docker/RtContainers.java 0 29 0.0%
Totals Coverage Status
Change from base Build 61: -25.8%
Covered Lines: 37
Relevant Lines: 80

💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 13, 2018

Pull Request Test Coverage Report for Build 65

  • 12 of 38 (31.58%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-18.3%) to 53.75%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtContainer.java 6 7 85.71%
src/main/java/com/amihaiemil/docker/RtContainers.java 4 29 13.79%
Totals Coverage Status
Change from base Build 61: -18.3%
Covered Lines: 43
Relevant Lines: 80

💛 - Coveralls

@amihaiemil
Copy link
Owner Author

@rultor good to merge

@rultor
Copy link
Collaborator

rultor commented Mar 13, 2018

@rultor good to merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f5a14a6 into master Mar 13, 2018
@amihaiemil amihaiemil deleted the 26 branch March 13, 2018 19:57
@rultor
Copy link
Collaborator

rultor commented Mar 13, 2018

@rultor good to merge

@amihaiemil Done! FYI, the full log is here (took me 2min)

@0crat
Copy link
Collaborator

0crat commented Mar 14, 2018

Job #43 is now in scope, role is REV

@amihaiemil
Copy link
Owner Author

@0crat out

@0crat
Copy link
Collaborator

0crat commented Mar 14, 2018

@0crat out (here)

@amihaiemil The job #43 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants