(#23) Implemented RemoteDocker #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New 'RemoteDocker' implementation of Docker * New 'DefaultHttpClient' implementing connection pooling
|
Job #64 is now in scope, role is |
llorllale
changed the title
Pull Request Test Coverage Report for Build 109
💛 - Coveralls |
amihaiemil
reviewed
Mar 24, 2018
| * @since 0.0.1 | ||
| * @checkstyle ParameterNumber (150 lines) | ||
| */ | ||
| final class DefaultHttpClient implements HttpClient { |
There was a problem hiding this comment.
@llorllale rename this to SSLHttpClient (since it's going to use the certificates to encrypt the requests) and leave a puzzle for exactly that: registering the http/https protocol using the provided certificates -- it's going to be similar to how unix is registered in UnixHttpClient.
As per PR review: * Renamed DefaultHttpClient -> SslHttpClient
|
@amihaiemil done, please review |
Forgot to rename DefaultHttpClientTestCase -> SslHttpClientTestCase
|
@rultor merge pls |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
The job #64 is now out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RemoteDockerSslHttpClientimplementing connection poolingRemoteDockerNote:
The implementation of
SslHttpClientis very minimal. I think we can just implement its operations as their need arises. It's also the reason why I added very few tests for it. It's the major reason why coverage decreases with this PR.