Merge b6f1537 into 01fcf77

amihaiemil · Oct 29, 2018 · 6bf1aed · 6bf1aed
2 parents 01fcf77 + b6f1537
commit 6bf1aed
Showing 1 changed file with 34 additions and 19 deletions.
diff --git a/src/main/java/com/amihaiemil/eojsonp/ConvenientJsonGenerator.java b/src/main/java/com/amihaiemil/eojsonp/ConvenientJsonGenerator.java
@@ -35,9 +35,6 @@
  * @author Mihai Andronache (amihaiemil@gmail.com)
  * @version $Id$
  * @since 0.0.1
- * @todo #8:30min Add implementations for JsonNumber and JsonString. They should
- *  also be unit tested and used in this class to delegate the convenience
- *  writing methods to the JsonValue ones.
  */
 abstract class ConvenientJsonGenerator implements JsonGenerator {
 
@@ -69,82 +66,100 @@ public abstract JsonGenerator write(
 
     @Override
     public JsonGenerator write(final String name, final String value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonString(value));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final BigInteger value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final BigDecimal value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final int value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final long value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final double value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String name, final boolean value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        //@checkstyle AvoidInlineConditionals (1 line)
+        this.write(name, new RtJsonString(value ? "true" : "false"));
+        return this;
     }
 
     @Override
     public JsonGenerator writeNull(final String name) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(name, new RtJsonString("null"));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final String value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonString(value));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final BigDecimal value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final BigInteger value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final int value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final long value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final double value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonNumber(String.valueOf(value)));
+        return this;
     }
 
     @Override
     public JsonGenerator write(final boolean value) {
-        throw new UnsupportedOperationException("Not supported yet.");
+        //@checkstyle AvoidInlineConditionals (1 line)
+        this.write(new RtJsonString(value ? "true" : "false"));
+        return this;
     }
 
     @Override
     public JsonGenerator writeNull() {
-        throw new UnsupportedOperationException("Not supported yet.");
+        this.write(new RtJsonString("null"));
+        return this;
     }
 
     @Override