Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.0.1 polyfills still not working properly in latest release #197

Closed
niftylettuce opened this issue Mar 19, 2019 · 4 comments
Closed

v3.0.1 polyfills still not working properly in latest release #197

niftylettuce opened this issue Mar 19, 2019 · 4 comments

Comments

@niftylettuce
Copy link

With contents: { settings: { polyfills: [ 'Promise' ] } }, the error message is:

Promise.resolve() is not supported in Opera Mobile 12.1, Opera Mini all, IE Mobile 10, IE 10, Blackberry Browser 7  compat/compat

Promise.reject() is not supported in Opera Mobile 12.1, Opera Mini all, IE Mobile 10, IE 10, Blackberry Browser 7   compat/compat

With contents: { settings: { polyfills: [ 'promises' ] } }, the error message is:

Promise is not supported in Opera Mobile 12.1, Opera Mini all, IE Mobile 10, IE 10, Blackberry Browser 7            compat/compat

Promise.resolve() is not supported in Opera Mobile 12.1, Opera Mini all, IE Mobile 10, IE 10, Blackberry Browser 7  compat/compat

Promise.reject() is not supported in Opera Mobile 12.1, Opera Mini all, IE Mobile 10, IE 10, Blackberry Browser 7   compat/compat

Which leads me to have to write out all the methods in order to pass (which I don't think is working as you intended, since Promise alone should work just fine, no?).

With contents: { settings: { polyfills: [ 'Promise', 'Promise.resolve', 'Promise.reject' ] } }, the error message is empty.

Also, in v2 to v3, you cannot use promises anymore, you have to use Promise. It would be nice to be able to use the generic caniuse ID again as we could in v2.

P.S. As a side note, could you please use np to publish new versions? The releases with this package have not been consistent at all and it should help. See https://github.com/sindresorhus/np/ for more info.


Btw I became your first supporter on Patreon just now! 🎉

Hope this helps 🙌 🙇

@amilajack
Copy link
Owner

amilajack commented Mar 19, 2019

Thank you! You're awesome 🎉 🎉 🎉 . The @next branch has the fix for this. Waiting for people to try it out before I push the patch for v3.0.2. Let me know if that it works for you.

P.S. As a side note...

Sure, I actually use np to publish. What can I change to make the publishing more consistent?

@niftylettuce
Copy link
Author

Oh, I had just filed #191 and didn't assume you used np. Will close that issue now that I know you do for the future.

@amilajack
Copy link
Owner

Btw I added a test case for the bug you're filing: #198. This passes in master and in eslint-plugin-compat@next. If @next does not work for you can you please PR a failing test case. Thanks!

@niftylettuce
Copy link
Author

I don't use @next versions in my projects in order to maintain stability. But I did test it and it seemed to work OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants