-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0.1 polyfills still not working properly in latest release #197
Comments
Thank you! You're awesome 🎉 🎉 🎉 . The
Sure, I actually use |
Oh, I had just filed #191 and didn't assume you used |
Btw I added a test case for the bug you're filing: #198. This passes in master and in |
I don't use |
With contents:
{ settings: { polyfills: [ 'Promise' ] } }
, the error message is:With contents:
{ settings: { polyfills: [ 'promises' ] } }
, the error message is:Which leads me to have to write out all the methods in order to pass (which I don't think is working as you intended, since
Promise
alone should work just fine, no?).With contents:
{ settings: { polyfills: [ 'Promise', 'Promise.resolve', 'Promise.reject' ] } }
, the error message is empty.Also, in v2 to v3, you cannot use
promises
anymore, you have to usePromise
. It would be nice to be able to use the generic caniuse ID again as we could in v2.P.S. As a side note, could you please use
np
to publish new versions? The releases with this package have not been consistent at all and it should help. See https://github.com/sindresorhus/np/ for more info.Btw I became your first supporter on Patreon just now! 🎉
Hope this helps 🙌 🙇
The text was updated successfully, but these errors were encountered: