Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in list when typing #592

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Search in list when typing #592

merged 2 commits into from
Aug 28, 2023

Conversation

anton-petrov
Copy link
Contributor

No need to click Search button, automatically search data afer 1 seconds delay.

Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

// Make a new timeout set to go off in 1000ms (1 second)
timeout = setTimeout(function () {
$('#search-button').click();
}, 1000);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue if 1 sec is a good number, but let's see if anyone has any issues with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, this value is obtained empirically based on my own experience. IMHO, 1 second is good enough.

@aminalaee aminalaee merged commit 067eadc into aminalaee:main Aug 28, 2023
6 checks passed
@aminalaee aminalaee mentioned this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants