Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx typing of Admin session_maker #604

Merged
merged 7 commits into from
Sep 15, 2023
Merged

Fx typing of Admin session_maker #604

merged 7 commits into from
Sep 15, 2023

Conversation

sheldygg
Copy link
Contributor

@sheldygg sheldygg commented Sep 2, 2023 •
edited by aminalaee

Closes #603

@sheldygg
Copy link
Contributor Author

sheldygg commented Sep 3, 2023

fix that

@aminalaee aminalaee changed the title fix typehint Admin.session_maker Fx typing of Admin session_maker Sep 15, 2023
aminalaee
aminalaee approved these changes Sep 15, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@aminalaee aminalaee merged commit 2ddfa58 into aminalaee:main Sep 15, 2023
4 checks passed
@aminalaee aminalaee mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issue with Admin session_maker type hint
2 participants
@sheldygg @aminalaee