fix broken link in doc #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
reviewed
Sep 16, 2023
There was a problem hiding this comment.
Hi, can you share what is the issue with the current URL?
I can see that it is working already in http://localhost:8080/sqladmin/cookbook/optimize_relationship_loading/
|
Interesting... I am not sure how to run this app locally. But on Github I get a 404: 
Same when I try to follow the link in my IDE: 
But it works here, so maybe it is not an issue: https://aminalaee.dev/sqladmin/cookbook/optimize_relationship_loading/ |
|
If you want to run this locally you can install But you are right, with your change it works both in mkdocs and also in Github file browser. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.