Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs: icon not rendered in writing custom views #664

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix docs: icon not rendered in writing custom views #664

merged 1 commit into from
Nov 3, 2023

Conversation

WiraDKP
Copy link
Contributor

@WiraDKP WiraDKP commented Nov 3, 2023

We should add fa-solid to properly render the fontawesome icon

Before:
before_docs

After:
after_docs

aminalaee
aminalaee approved these changes Nov 3, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR 👍

@aminalaee aminalaee merged commit d688968 into aminalaee:main Nov 3, 2023
6 checks passed
@WiraDKP WiraDKP deleted the fix-docs branch November 3, 2023 16:31
@aminalaee aminalaee mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WiraDKP @aminalaee