Skip to content

Commit

Permalink
update readme
Browse files Browse the repository at this point in the history
  • Loading branch information
aminomancer committed Feb 1, 2022
1 parent 28d4e14 commit d78cb0f
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,7 @@ This is a standard theme, not a "high-contrast theme" or a "compact theme." I ai

The basic aim of this theme's colors can be summed up as "dark mode." I think dark gray is a little boring and overdone, so I went with dark indigo and slate colors in the UI, and dark gray in content. As everything revolves around "dark mode," any instance of a big white interface is jarring and creates a negative user experience. So the theme modifies every parent process interface and even many content interfaces to eliminate these light vestiges. It includes stylesheets for some specific websites, but by and large you're expected to use [Dark Reader](https://addons.mozilla.org/firefox/addon/darkreader) if you want consistent dark content. It also includes stylesheets for several extension pages, since Dark Reader can't style most of them.

One of the biggest changes in Proton had to do with icons. Large swathes of icons were removed and many basic icons were redesigned with much thinner strokes. I don't think this was a wise change. For one, the new icon style doesn't look as good or as distinctively "Mozilla" as the previous icon style. But it has created an enormouse amount of work for Mozilla that isn't even being tackled. Even Firefox itself hasn't updated every icon to the new "thin" style. Many icons are mismatched. But if you look at virtually any other Mozilla product you'll see they're still using the old icons.

On every page of [addons.mozilla.org](https://addons.mozilla.org/firefox/) you can see the old style of icons. Sometimes it's just a minor visual difference, but other times you can hardly identify the new icon with the old icon. This is especially problematic for icons like [tab.svg](/resources/skin/tab.svg) whose shapes were [dramatically changed](https://searchfox.org/mozilla-central/rev/bd24fa92d94874587f6fb36177a05291b8c03b95/browser/themes/shared/icons/tab.svg). So now all these products and webpages will need to be updated with the new icons. By the time that gets finished, Firefox will probably have already moved on to yet another new icon style.

So, one of the objectives of this theme is to restore all the icons to their pre-Proton style. And it does that pretty successfully by using a [component manifest](#resources--manifest) to replace the icons just upstream of the IO level. Another objective is to add icons back to menus. I think Proton is generally an improvement over Photon, but many people would agree that Proton often looks for minimalism in the wrong places. To create clean, simple menus evocative of Google Chrome, Firefox has removed icons from virtually every menu, and in doing so, has fallen behind Microsoft Edge in visual clarity. The worst part is that Firefox extensions still add icons to these menus, creating a glaring inconsistency.

I spent hundreds of hours reconstructing these [menu icons](/uc-context-menu-icons.css). I think part of the reasoning behind removing these icons was that not all of the menus had icons in the first place, and too many reused icons. They were inconsistent from the start, because apparently Mozilla doesn't have enough illustrators. So in restoring menu icons, I often had to source new icons, but Mozilla's pre-Proton icons are very distinctive. So I have designed dozens of new icons to adhere to the pre-Proton visual style. It's been a long-running effort but essentially every menu item in the main UI has icons. If any are missing, please post an [issue](/../../issues/new/choose) so I can resolve it.
One of the objectives of this theme is to restore all the icons to their pre-Proton style. This isn't strictly necessary, but with Proton, the icon style was changed and a bunch of icons were removed simultaneously, so many icons never got an update. That means if we want context menu icons, we need to use the old icon style or make new icons (this theme does a mix of both). I generally liked the old icon style, so that's the direction I took the theme in. Eventually I may change my mind and aim for a less busy, icon-free style like Proton. But until then we'll use a mix of pre-Proton icons, Google Material icons, and my own custom icons.

I said before that this is not a "compact theme," but I think my idea of "normal density" is a bit more compact than the Proton designers'. So, one of the principles is to compactify anything that is superfluously large. For example, Firefox's Findbar has always been needlessly huge, filling an arbitrarily large amount of horizontal space with emptiness, while simultaneously wasting vertical space. One of the very first things I did with this theme was to turn the Findbar into a floating panel of about 400 x 40px. It floats on top of the content rather than pushing it up or down. I turned all the buttons and checkboxes into icons. It wound up looking very much like VS Code's findbar, so I decided to use VS Code's icons for it.

Expand Down

0 comments on commit d78cb0f

Please sign in to comment.