Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #4

Open
aminophen opened this issue Sep 17, 2022 · 5 comments
Open

TODO #4

aminophen opened this issue Sep 17, 2022 · 5 comments

Comments

@aminophen
Copy link
Owner

aminophen commented Sep 17, 2022

  • Windows does not have "rm"
  • Documentation: can "chemobabelimgdir" be changed via \renewcommand ? → No! (If "chemobabelimgdir" can be changed or user-defined "Prefix" is allowed, extra hacks on LuaTeX will be required. Twitter)
  • Documentation: mention GitHub in the dtx/pdf also → Done (2022-09-19)
@aminophen
Copy link
Owner Author

aminophen commented Sep 19, 2022

  • Syntax of \chemobabel/\smilesobabel command: some people complains about the second optional argument, so adding \chemobabel*/\smilesobabel* variant with only one argument → Done (462f9a8)
  • Warn if a user need to run another latex (Note: running without -shell-escape after removing [extract] should not issue a warning) → An idea of writing the number of images by \chemobabel/\smilesobabel into .aux file, and read it on the second run to see if the number changed ? → Done in 9fea08b and 4f00bf6

@aminophen
Copy link
Owner Author

aminophen commented Oct 8, 2022

  • Handle options in the order they are given → Done in 667b2ef and 2dd5ed6
  • Safety check of \jobname before opening ChemFigFile.tex on [extract] → Done (e448147)
  • Pass the original package options into extracted ChemFigFile.tex → Done (d69604d)

@aminophen
Copy link
Owner Author

aminophen commented Oct 8, 2022

  • Default image format EPS when the engine/driver does not support PDF, by detecting graphicx driver (e.g. latex+dvips) → Done (f934c91)

@aminophen
Copy link
Owner Author

aminophen commented Oct 12, 2022

Documentations → All done (61a6786)

  • Restriction: when using -output-directory, the extracted code "ChemFigFile.tex" goes there but chemobabelimgdir and generated images stay in the current directory. (Note: the .aux file goes to given output directory, but the engine reads .aux in the output directory first, so it's fine)
  • A bit more documentation for default cropping, including:
    • pdfcrop or ps2eps should be found on PATH
    • \includegraphics option [clip] is useful for proper EPS cropping
  • Documentation for automatic default PDF/EPS selection of f934c91 for next release

@aminophen
Copy link
Owner Author

Remainings:

  • Windows does not have "rm"; what is the best way of removing a file on Windows?
  • Recent version(s) of "rsvg-convert" generates PDF-1.7 by default, which is higher than what TeX world expects so raises warnings:
pdfTeX warning: pdflatex (file ./chemobabelimgdir/smilesobabelimg1-crop.pdf): PDF inclusion: found PDF version <1.7>, but at most version <1.5> allowed
dvipdfmx:warning: Trying to include PDF file with version (1.7), which is newer than current output PDF setting (1.5).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant