Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use build/install instead of setuptools #319

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

gardar
Copy link
Contributor

@gardar gardar commented Nov 7, 2023

invoking setup.py directly is deprecated:
https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

@gardar
Copy link
Contributor Author

gardar commented Nov 7, 2023

@aminvakil this now builds correctly, but it looks like the CI is failing on a unrelated error.

@aminvakil aminvakil changed the base branch from ansible_cmdb_test to master November 7, 2023 13:38
Copy link
Owner

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error was because multiple packages differ from the master and it was trying to build them all, I've also changed base branch to master and did some tweaks and it's OK now, thanks!

@aminvakil aminvakil merged commit b6ca985 into aminvakil:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants