Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Base.sort in order to avoid ambiguities #27

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

casabre
Copy link
Contributor

@casabre casabre commented Nov 11, 2020

There are package that are providing a sort implementation as well. This leads to the following error, e.g. with Redis.jl

WARNING: both Redis and Base export "sort"; uses of it in module Main must be qualified
ERROR: UndefVarError: sort not defined

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #27 (aa3392d) into master (438d44b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files           7        7           
  Lines         415      415           
=======================================
  Hits          301      301           
  Misses        114      114           
Impacted Files Coverage Δ
src/snoop_bot.jl 75.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ebc54...aa3392d. Read the comment docs.

@aminya aminya merged commit 39a3121 into aminya:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants