Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new JavaScript + More robust processing + Update dependencies #2

Merged
merged 22 commits into from
Jan 20, 2021
Merged

Support new JavaScript + More robust processing + Update dependencies #2

merged 22 commits into from
Jan 20, 2021

Conversation

aminya
Copy link
Owner

@aminya aminya commented Jan 20, 2021

  • Support parsing new JavaScript
  • More robust processing by continuing on undefined or unknown errors
  • Update dependencies
  • Fix the failing tests
  • Add GitHub Actions

Successful CI run:
https://github.com/aminya/jsdoc2flow/actions/runs/497438424

@aminya
Copy link
Owner Author

aminya commented Jan 20, 2021

@dannysu Hi! I updated this library. I would like to maintain this project. If you are not interested in maintaining it, could you transfer the repo to me?

@aminya aminya changed the title Update dependencies Support new JavaScript + More robust processing + Update dependencies Jan 20, 2021
@dannysu
Copy link
Collaborator

dannysu commented Jan 20, 2021

Not sure how to transfer to you, but happy to. Github says you already have a repo named the same.

Do you have a npmjs.com account?

@aminya
Copy link
Owner Author

aminya commented Jan 20, 2021

@dannysu Could you try again? I renamed my fork.

Do you have a npmjs.com account?

Yes! This is my ID: @aminya

BTW, thank you! 😃

@dannysu dannysu merged commit 866c6f7 into aminya:master Jan 20, 2021
@dannysu
Copy link
Collaborator

dannysu commented Jan 20, 2021

Still get the message "aminya already has a repository in the dannysu/jsdoc2flow network". I think maybe because you already have a forked repo?

Added you to npm. Feel free to take over.

@aminya
Copy link
Owner Author

aminya commented Jan 20, 2021

Still get the message "aminya already has a repository in the dannysu/jsdoc2flow network". I think maybe because you already have a forked repo?

Hmm, 🤔 I have deleted the fork now. Maybe, you can do it now.

Added you to npm. Feel free to take over.

Thanks. I have big plans for the code. I am mostly interested in integrating it to flow-to-ts as I specified in #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants