Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in macro enable_native_optimization #89

Closed
ljishen opened this issue Mar 2, 2022 · 1 comment · Fixed by #90
Closed

Error in macro enable_native_optimization #89

ljishen opened this issue Mar 2, 2022 · 1 comment · Fixed by #90
Labels
bug Something isn't working

Comments

@ljishen
Copy link

ljishen commented Mar 2, 2022

I got the error:

CMake Error at build/_deps/_project_options-src/src/Optimization.cmake:18 (target_compile_options):
  Cannot specify compile options for target "PRIVATE" which is not built by
  this project.

The reason is that the macro lacks a parameter to receive project_name.
@aminya aminya mentioned this issue Mar 2, 2022
Merged
@aminya aminya added the bug Something isn't working label Mar 2, 2022
@aminya
Copy link
Owner

aminya commented Mar 2, 2022

@ljishen Please review this pull request that fixes this issue: #90

@aminya aminya closed this as completed in #90 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix native optimization aminya/project_options
2 participants
@ljishen @aminya