Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SYSTEM includes when supported on WIN32 #164

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Enable SYSTEM includes when supported on WIN32 #164

merged 1 commit into from
Oct 11, 2022

Conversation

SK83RJOSH
Copy link
Contributor

Fixes #162

aminya
aminya approved these changes Oct 8, 2022
View reviewed changes
Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aminya aminya merged commit 397f027 into aminya:main Oct 11, 2022
@SK83RJOSH SK83RJOSH deleted the win32-sys-includes branch October 11, 2022 12:09
@aminya
Copy link
Owner

aminya commented Oct 19, 2022

@SK83RJOSH Your pull requests are qualified for Hacktoberfest 2022. Feel free to claim your prize at:
https://hacktoberfest.com/

@SK83RJOSH
Copy link
Contributor Author

@SK83RJOSH Your pull requests are qualified for Hacktoberfest 2022. Feel free to claim your prize at: https://hacktoberfest.com/

Oh thanks for the heads-up! I actually haven't qualified for Hacktoberfest since the very first one years and years ago. Ended up losing the shirt somewhere along the way... 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake now supports SYSTEM includes on Windows for Ninja/MSVC
2 participants
@SK83RJOSH @aminya