Allow passing build and host profiles through to conan #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
reviewed
Jan 21, 2023
Comment on lines
+80
to
+84
| if("${ProjectOptions_CONAN_PROFILE}" STREQUAL "") | ||
| set(CONAN_DEFAULT_PROFILE "default") | ||
| else() | ||
| set(CONAN_DEFAULT_PROFILE ${ProjectOptions_CONAN_PROFILE}) | ||
| endif() |
There was a problem hiding this comment.
This can be moved under the if section of the next condition. It would potentially simplify the code a bit.
aminya
approved these changes
Jan 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional variables with sensible defaults so that users may specify a host and/or build profile for the cmake_install_command. This is useful in cross compiling scenarios where the single profile argument is not enough.