fix: Parallel configure failure. #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to configure multiple build directories in parallel project_options will try to create a symlink for compile_commands.json; multiple symlinks will be created at the same time with different targets, obviously this fails; Add a way to disable the symlink creation. This also fixes CMake failing to configure projects with a read-only sources directory.
aminya
approved these changes
May 2, 2023
aminya
requested changes
May 2, 2023
|
@aminya Do you want to make the "compile_commands.json" symlink disabled by default then? In the current version of the PR it stays enabled by default. |
Yeah, it seems it is causing issues as you mentioned. I prefer that we disable it by default to avoid any problems. |
aminya
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to configure multiple build directories in parallel project_options will try to create a symlink for compile_commands.json; multiple symlinks will be created at the same time with different targets, obviously this fails; Add a way to disable the symlink creation.
This also fixes CMake failing to configure projects with a read-only sources directory.