Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation Overlapping #113

Closed
ryanfitzer opened this issue Oct 9, 2018 · 8 comments
Closed

Animation Overlapping #113

ryanfitzer opened this issue Oct 9, 2018 · 8 comments
Labels

Comments

@ryanfitzer
Copy link

Only happens when you use loop AND have only 2 frames. Add a 3rd frame and the issue goes away.

The current frame animates to the right and the incoming frame animates in from the left, overlapping the current frame's animation.

animation

@amio amio added the bug label Oct 10, 2018
@amio
Copy link
Owner

amio commented Oct 10, 2018

I think this can be fixed in the rewrite with react-motion. We should remove those hidden frames from DOM tree, inject new frame at the beginning of every switch.

@ryanfitzer
Copy link
Author

Haven’t used react-motion before, but sounds like a good plan.

@hemel-cse
Copy link

Also having this issue.

@ryanfitzer
Copy link
Author

@amio Do you have an idea when you expect to release this update?

@amio
Copy link
Owner

amio commented Oct 24, 2018

Hmm, I should fix it on current version first. Don't have too much time experimenting on react-motion recently.

@amio
Copy link
Owner

amio commented Oct 24, 2018

Fixed in v2.3.0.
@ryanfitzer @hemel-cse You may have a try now :D

@ryanfitzer
Copy link
Author

Works like a charm! Thanks for the quick turnaround.

@hemel-cse
Copy link

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants