Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for reading message headers #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaxap
Copy link

@kaxap kaxap commented Jun 27, 2020

Addressing #23

@kaxap
Copy link
Author

kaxap commented Jun 27, 2020

@jgallagher is this fine, or is it better to create an example file in examples folder?

@kaxap
Copy link
Author

kaxap commented Jul 7, 2020

bump

@kaxap
Copy link
Author

kaxap commented Aug 1, 2020

any feedback on this?

@jgallagher
Copy link
Collaborator

@kaxap Sorry I left this hanging for so long! This doesn't work as currently written because the delivery module is private, so the example you added doesn't show up in the generated pages from rustdoc.

I think it would be great to add something that demonstrates this to the examples, though. All the current examples have a partner example that can be run at the same time to see it in action. What would you think about this plus a corresponding example that sends messages with a custom header set?

@kaxap
Copy link
Author

kaxap commented Dec 26, 2020

hey, thanks for the reply! Unfortunately, I am not programming in rust for the last couple of months. I'll give this MR another try maybe in 3-4 weeks time if that's okay.

@jgallagher
Copy link
Collaborator

Sure, no problem! 👍

I left this hanging for a long time, take as much time as you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants