You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using namespace std in header file will pollute all implementation files that include the header. The practice is to use std::string, std::vector, etc. in header.
Use size_t instead of int for size of array/object and indices. Otherwise there are a lot of related warnings.
This will make a deep copy of the whole subtree for every call.
If the library is designed for read-only access to the parse result (as I cannot find APIs for modifying existing values), I will suggest to change all APIs as const member functions:
using namespace std
in header file will pollute all implementation files that include the header. The practice is to usestd::string
,std::vector
, etc. in header.size_t
instead ofint
for size of array/object and indices. Otherwise there are a lot of related warnings.jValue
by value.This will make a deep copy of the whole subtree for every call.
If the library is designed for read-only access to the parse result (as I cannot find APIs for modifying existing values), I will suggest to change all APIs as const member functions:
While the other write-access API can be private and makes
parser
friend ofjValue
.The text was updated successfully, but these errors were encountered: