Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escapes avatar url correctly. see #2601 #2602

Merged
merged 2 commits into from
Dec 17, 2023
Merged

fix: escapes avatar url correctly. see #2601 #2602

merged 2 commits into from
Dec 17, 2023

Conversation

amir20
Copy link
Owner

@amir20 amir20 commented Dec 17, 2023

No description provided.

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

@EDIflyer can you try this? amir20/dozzle:pr-2602.

While I wasn't able to reproduce your problem exactly, I did find another bug.

If the issue still happens, then please enable debug logs and send me the log that says Fetching avatar from....

Thanks!

@EDIflyer
Copy link
Contributor

Yep still happening -
level=debug msg="Fetching avatar from https://gravatar.com/avatar/617016fc8b09804be4fbfa5eb2054ac9?d=https%3A%2F%2Fui-avatars.com%2Fapi%2F//128"

When I try that I get the 12 image that you're then showing.

When I look up the email address that's being passed through from Authelia (that you correctly pick up on hover) - I get this error on the Gravar.com website, which is what I would expect as I haven't registered that address with them...
image

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

I see what the problem is now. According to that URL, your displayname is empty? Can you confirm what Authelia is passing to Dozzle for Remote-Name?

I don't have the exact set up as you but I'll try to look at documentation.

When I look up the email address that's being passed through from Authelia (that you correctly pick up on hover) - I get this error on the Gravar.com website, which is what I would expect as I haven't registered that address with them...

Yes, it should just show your initials for your name when Gravatar doesn't exist. For you it would be AR. Which ironically would same initials as me.

@EDIflyer
Copy link
Contributor

Authelia is setup with displayname - I noticed in the dB for this is wasn't in quotes but was for the other site - I tried changing it but no change. Not sure where I can see what Remote-Name is passed to Dozzle as it doesn't appear in the debug logs?

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

I don't print it. But you can use that other app you had found to print all the headers. Let me know if it's easier for me to add logs.

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

@EDIflyer I think I found the problem. I found your old comment #2437 (comment) which shows your setup doesn't have Remote Name. If you remember we were actually discussing this.

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

OK test with amir20/dozzle:pr-2602 again. Now if name is blank I use username instead.

@EDIflyer
Copy link
Contributor

EDIflyer commented Dec 17, 2023

@EDIflyer I think I found the problem. I found your old comment #2437 (comment) which shows your setup doesn't have Remote Name. If you remember we were actually discussing this.

Ah yes, I'd forgotten that wasn't passed through!

Yep that makes more sense now - it's got the first couple of characters of the username...
image

PS I couldn't work out where the 12 was coming from but I then spotted the tooltip on the tab said '12 containers' so not sure if it was somehow coming from that?! 😂

@amir20
Copy link
Owner Author

amir20 commented Dec 17, 2023

The 12 is from 128 size I pass to the avatar service. Since the name was empty it thought username is 128.

Finally figured this out. 🤓

@amir20 amir20 merged commit 6b09fc4 into master Dec 17, 2023
7 checks passed
@amir20 amir20 deleted the avtar-encoded branch December 17, 2023 22:26
@EDIflyer
Copy link
Contributor

EDIflyer commented Dec 17, 2023

Haha love it @amir20 - shame it wasn't 42 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants