Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create implementation doesn't work (0.0.6) #5

Closed
SergeyFi opened this issue Apr 3, 2020 · 3 comments
Closed

Create implementation doesn't work (0.0.6) #5

SergeyFi opened this issue Apr 3, 2020 · 3 comments

Comments

@SergeyFi
Copy link

SergeyFi commented Apr 3, 2020

Hi, cool extension but on version 0.0.6 "Create implementation" doesn't work.
On version 0.0.5 everything works fine.
What information do I need to provide so that you can fix the bug?

VSCode version: 1.43.2
OS:Windows 10 x64.

@amir9480
Copy link
Owner

amir9480 commented Apr 3, 2020

Hello.
Thanks for using C++ Helper.

First, check if you can see Function not detected. message when you click "Create implementation". If you see that then please send a sample header code that does not work and tell exactly where you right-clicked.

Otherwise, please follow these instructions.
#1 (comment)

@SergeyFi
Copy link
Author

SergeyFi commented Apr 4, 2020

Hi. I followed the instructions and here is the result:

8667.log
exthost-c85225.cpuprofile.txt

Code examples:
NutrientsComponent.cpp.txt
NutrientsComponent.h.txt

P.S I noticed that the implementation was eventually created, but with a big lag.

P.P.S I tried on another PC, a similar story.
85993234334.log
exthost-aa8b87.cpuprofile.txt

amir9480 added a commit that referenced this issue Apr 4, 2020
@amir9480
Copy link
Owner

amir9480 commented Apr 4, 2020

I tested regex on your code and figured out this happening because of Unreal Engine macros like ( UCLASS, GENERATED_BODY, ... ) causing the problem because of no ";" at end of the line so regex takes too much time to parse.

I optimized regex based on your code and now it looks like working.
Please update to version 0.0.7 and if still any issue exists let me know.
Thank you.

@amir9480 amir9480 closed this as completed Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants