Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --force option to the localize command #56

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

filip-nifti
Copy link
Contributor

The Localize command implements the ConfirmableTrait but does not have a --force option.
This makes it impossible to use the command programmatically and bypass the "Do you really wish to run this command?" Which you are supposed to be able to do using the --force option.

I did not add any tests since i did not manage to change the environment to production to force the question "Do you really wish to run this command? " therefore i could not create any assertions.

But it does work and it is a minor change that only implements a trait. Just an option no further code changes. All the previous tests pass as expected.

@amiranagram
Copy link
Owner

amiranagram commented Apr 24, 2023

Environment can be changed with app()->detectEnvironment(fn () => 'production'), but nevertheless, I don't think tests are needed anyway. Thanks. Released as a patch. @filip-nifti

@amiranagram amiranagram merged commit 4bfa8cd into amiranagram:0.x Apr 24, 2023
10 checks passed
@filip-nifti
Copy link
Contributor Author

Ah, thanks good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants