set default bufferedMessaging in ThreadPool

CHANGELOG.md

@@ -1,5 +1,10 @@
 ## HappyPack Changelog
 
+### 4.0.0-beta.4
+
+- Default to buffered messaging mode when using standalone thread pools on
+  Windows.
+
 ### 4.0.0-beta.3
 
 Fixed bug around the use of `process.send()` that was causing a hang on

lib/HappyPlugin.js

@@ -9,7 +9,6 @@ var fnOnce = require('./fnOnce');
 var ErrorSerializer = require('./ErrorSerializer');
 var pick = require('./pick');
 var pkg = require('../package.json');
-var os = require('os');
 
 function HappyPlugin(userConfig) {
   if (!(this instanceof HappyPlugin)) {
@@ -42,7 +41,7 @@ function HappyPlugin(userConfig) {
     // we don't want this to be documented / exposed since it's an
     // implementation detail + not having it on means a bug, but we're making it
     // configurable for testing purposes
-    bufferedMessaging:        { type: 'boolean', default: os.platform() === 'win32' },
+    bufferedMessaging:        { type: 'boolean', default: process.platform === 'win32' },
     loaders:                  {
       validate: function(value) {
         if (!Array.isArray(value)) {

lib/HappyThreadPool.js

@@ -44,7 +44,9 @@ module.exports = function HappyThreadPool(config) {
     id: config.id,
     verbose: config.verbose,
     debug: config.debug,
-    buffered: config.bufferedMessaging,
+    buffered: config.hasOwnProperty('bufferedMessaging') ?
+      config.bufferedMessaging :
+      process.platform === 'win32',
   });
 
   var getThread = RoundRobinThreadPool(threads);