Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #8 including test reproducing the problem. #13

Merged
merged 4 commits into from
Sep 1, 2019

Conversation

createthis
Copy link
Contributor

This was originally #9, but the branch got messed up after rebasing (necessary due to commit lint), so I made a new branch and cherry-picked the commits

Fix for #8 including test reproducing the problem.

@@ -1,9 +0,0 @@
MIT License
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #14

Copy link
Owner

@amirfefer amirfefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @createthis 👍 , works well !

@amirfefer amirfefer merged commit 161c69a into amirfefer:master Sep 1, 2019
@amirfefer
Copy link
Owner

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants