Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README #62

Merged
merged 4 commits into from
Feb 11, 2024
Merged

update README #62

merged 4 commits into from
Feb 11, 2024

Conversation

Pify
Copy link
Contributor

@Pify Pify commented Feb 11, 2024

No description provided.

@@ -0,0 +1,22 @@
package com.frogobox.appkeyboard.util

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/util/KeyboardNavigationHelper.kt is not ending with a new line.
import android.view.ViewGroup
import com.frogobox.libkeyboard.common.core.BaseKeyboard

class KeyboardNavigationHelper {

Check warning

Code scanning / detekt

The class declaration is unnecessary because it only contains utility functions. An object declaration should be used instead. Warning

The class KeyboardNavigationHelper only contains utility functions. Consider defining it as an object.
Copy link
Owner

@amirisback amirisback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirisback amirisback merged commit 1c65624 into amirisback:master Feb 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants