Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE :: Theme Keyboard #65

Merged
merged 9 commits into from
Mar 16, 2024
Merged

FEATURE :: Theme Keyboard #65

merged 9 commits into from
Mar 16, 2024

Conversation

amirisback
Copy link
Owner

@amirisback amirisback commented Feb 16, 2024 •
edited
Loading

Feature Request : #63

@amirisback amirisback added the enhancement New feature or request label Feb 16, 2024
@amirisback amirisback self-assigned this Feb 16, 2024
@amirisback amirisback mentioned this pull request Feb 16, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 16, 2024
View reviewed changes
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt Fixed Show fixed Hide fixed
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt Fixed Show fixed Hide fixed
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt
data: KeyboardFeature,
position: Int,
notifyListener: FrogoRecyclerNotifyListener<KeyboardFeature>,
) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt Fixed Show fixed Hide fixed
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt
data: KeyboardFeature,
position: Int,
notifyListener: FrogoRecyclerNotifyListener<KeyboardFeature>,
) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/di/RepositoryModule.kt
@@ -1,4 +1,4 @@
package com.frogobox.appkeyboard.di.hilt
package com.frogobox.appkeyboard.di

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/di/RepositoryModule.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/di/NetworkModule.kt
@@ -1,4 +1,4 @@
package com.frogobox.appkeyboard.di.hilt
package com.frogobox.appkeyboard.di

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/di/NetworkModule.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/di/DatabaseModule.kt
@@ -1,4 +1,4 @@
package com.frogobox.appkeyboard.di.hilt
package com.frogobox.appkeyboard.di

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/di/DatabaseModule.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/di/UtilModule.kt
@@ -1,4 +1,4 @@
package com.frogobox.appkeyboard.di.hilt
package com.frogobox.appkeyboard.di

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/di/UtilModule.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleViewModel.kt Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 16, 2024
View reviewed changes
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt
data: KeyboardFeatureModel,
position: Int,
notifyListener: FrogoRecyclerNotifyListener<KeyboardFeatureModel>,
) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleActivity.kt
data: KeyboardFeatureModel,
position: Int,
notifyListener: FrogoRecyclerNotifyListener<KeyboardFeatureModel>,
) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeActivity.kt
data: KeyboardThemeModel,
position: Int,
notifyListener: FrogoRecyclerNotifyListener<KeyboardThemeModel>
) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeViewModel.kt

fun setThemeColor(color: Int, onSuccess: () -> Unit) {
pref.savePrefInt(KeyboardUtil.KEYBOARD_COLOR, color, object : FrogoStateResponse {
override fun onFailed(statusCode: Int, errorMessage: String) {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeViewModel.kt
fun setThemeColor(color: Int, onSuccess: () -> Unit) {
pref.savePrefInt(KeyboardUtil.KEYBOARD_COLOR, color, object : FrogoStateResponse {
override fun onFailed(statusCode: Int, errorMessage: String) {}
override fun onFinish() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleViewModel.kt
@@ -0,0 +1,43 @@
package com.frogobox.appkeyboard.ui.toggle

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/ui/toggle/ToggleViewModel.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeActivity.kt
@@ -0,0 +1,133 @@
package com.frogobox.appkeyboard.ui.theme

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeActivity.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeViewModel.kt
@@ -0,0 +1,53 @@
package com.frogobox.appkeyboard.ui.theme

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/ui/theme/ThemeViewModel.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/model/KeyboardThemeType.kt
@@ -0,0 +1,38 @@
package com.frogobox.appkeyboard.model

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/model/KeyboardThemeType.kt is not ending with a new line.
app/src/main/java/com/frogobox/appkeyboard/model/KeyboardThemeModel.kt
@@ -0,0 +1,17 @@
package com.frogobox.appkeyboard.model

Check warning

Code scanning / detekt

Checks whether files end with a line separator. Warning

The file /home/runner/work/keyboard/keyboard/app/src/main/java/com/frogobox/appkeyboard/model/KeyboardThemeModel.kt is not ending with a new line.
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 16, 2024
View reviewed changes
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt
@@ -144,38 +144,29 @@
currentInputConnection?.commitText(text, 0)
}

override fun initialSetupKeyboard() {
override fun initialSetupKeyboard() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt

}
override fun setupTheme() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt
override fun showMainKeyboard() {

}
override fun initCurrentInputConnection() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt

override fun showOnlyKeyboard() {
override fun hideMainKeyboard() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt

}
override fun showMainKeyboard() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt

override fun hideOnlyKeyboard() {
override fun showOnlyKeyboard() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
frogo-keyboard/src/main/java/com/frogobox/libkeyboard/common/core/BaseKeyboardIME.kt

}
override fun hideOnlyKeyboard() {}

Check warning

Code scanning / detekt

Empty block of code detected. As they serve no purpose they should be removed. Warning

This empty block of code can be removed.
@amirisback amirisback merged commit 58dc1af into master Mar 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amirisback amirisback

Labels
enhancement New feature or request
Projects
Faisal Amir Open Sources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@amirisback