Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with english #38

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Update with english #38

merged 11 commits into from
Mar 27, 2024

Conversation

Mkadir
Copy link
Contributor

@Mkadir Mkadir commented Mar 22, 2024

This pr for replacing some vars translated to English. I respect your language, but in production it is hard to use, becauese some vars still in Chinese after setting LANGUAGE=en_US to .env. And that's why I'm sending this request. English is not my native language either, but Chinese is more difficult to understand than English. I hope you understand correctly.

Copy link
Owner

@amisadmin amisadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your translation work, I will generate the corresponding locale file as soon as possible, and merge and publish to the main version.

Copy link
Contributor Author

@Mkadir Mkadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your attention and I want to ask about the main readme, I will say this while respecting your language. I would like you to look into this as well, a clear readme for the tool would definitely increase the scope of users.

@amisadmin amisadmin merged commit ed703b5 into amisadmin:master Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants