-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devcontainer+docker): Add devcontainer and docker support #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
36e77fc
to
8c4d37f
Compare
ef9511f
to
fb98c05
Compare
003381a
to
adffa51
Compare
Earlier, we used to stop by sending a remote command to the remote neovim instance. This caused issues in cases where the remote instance is blocked by a sync operation. Now, we kill the job handling the process which in turn kills the remote job for us.
041a5f0
to
69799e5
Compare
Time to add docs 🎉 |
264ffa0
to
31e437b
Compare
9dcee72
to
02740a6
Compare
2ac3f4d
to
71d261b
Compare
0025cfa
to
74a7255
Compare
Hostname ending in a `-` breaks devpod and/or ssh.
4fe1aa1
to
978dcec
Compare
3d9c6a0
to
f01778b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
Closes #69
Using devpod CLI to power the process, we are going to provide docker and devcontainer support.
Following tasks should be completed to get this ready:
devpod
binary