Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Provide an option to take text input #21

Closed
amitguptagwl opened this issue Sep 25, 2018 · 14 comments
Closed

Demo: Provide an option to take text input #21

amitguptagwl opened this issue Sep 25, 2018 · 14 comments
Labels

Comments

@amitguptagwl
Copy link
Collaborator

In the current implementation text is hard coded. We want to give an option so that user can try the demo with different text. For this;

  1. Add a button on the screen.
  2. On click of that button, open a popup to take multiline text input.
  3. restart the demo with new text.
@asingh217
Copy link

Hello, I would like to work on this issue.

@amitguptagwl
Copy link
Collaborator Author

amitguptagwl commented Sep 25, 2018

Yes, please.

Please join the Team to support opensource projects
Please bookmark this project to support us

@asingh217
Copy link

Thanks, I will start working on this.

@msarfrazanwar
Copy link

In the current implementation text is hard coded. We want to give an option so that user can try the demo with different text. For this;

  1. Add a button on the screen.
  2. On click of that button, open a popup to take multiline text input.
  3. restart the demo with new text.

Hey , Can i also work on this ?

@amitguptagwl
Copy link
Collaborator Author

2 people together? No!! Let give some time to @asingh217 . If she doesn't finish it within a week or if there is no update then you can pick it. You can check more issues here

Please join the Team to support opensource projects
Please bookmark this project to support us

@msarfrazanwar
Copy link

Ok , I will look for some other projects then.

@ashishpatelcs
Copy link
Contributor

@asingh217 Let me know if there is an issue. I can help you test from my end.

@asingh217
Copy link

@asingh217 Let me know if there is an issue. I can help you test from my end.

Thanks @ashishpatelcs , I need some suggestion on UI items like the

  1. Button Name
  2. Modal dialog Title
    I have implemented the functional part. It will be helpful if you can review it and share your feedback.

Please let me know how to do i share my code. Should i share the commit page link here from my fork.

@amitguptagwl
Copy link
Collaborator Author

Here is your code changes: https://github.com/asingh217/shabdawali

@ashishpatelcs
Copy link
Contributor

ashishpatelcs commented Sep 25, 2018

@asingh217 It would be better you can have it live on your GitHub pages so that I can see it working. Have you checked the code you've edited to work on your local machine? I have some doubts about it.

Also, you can name the button like 'edit' or better you can use something like fontawesome or pencil like graphics.
About the model dialog title, I think you can use something like 'Custom Text' or plain 'Edit' again.

@amitguptagwl can enlighten us with some better ideas.

Let's make it work.

@amitguptagwl
Copy link
Collaborator Author

Here are the common fonts which are small in size and fulfill out need. Or you may simply use a button with text "edit text"

@ashishpatelcs You can check her changes here: http://htmlpreview.github.io/?https://github.com/asingh217/shabdawali/blob/master/index.html

@ashishpatelcs
Copy link
Contributor

ashishpatelcs commented Sep 25, 2018

@amitguptagwl Thank you.

@asingh217 Your button and the modal box is working perfectly fine.

@asingh217
Copy link

Thanks, I have updated the title and button name.
I will create a pull request.

@ashishpatelcs
Copy link
Contributor

I think this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants