Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing returning null bitmap by reiteration of stream actions #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixing returning null bitmap by reiteration of stream actions #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6abf46e
Update GlideBitmapFactory.java
maxlab-code Sep 12, 2019
e6afbf5
Fixing returning null bitmap by reiteration of stream actions
maxlab-code Sep 12, 2019
6086c79
Update GlideBitmapFactory.java
maxlab-code Sep 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions glide-bitmap-pool/src/main/java/com/glidebitmappool/GlideBitmapFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import com.glidebitmappool.internal.Util;

import java.io.FileDescriptor;
import java.io.IOException;
import java.io.InputStream;

/**
Expand Down Expand Up @@ -172,10 +173,19 @@ public static Bitmap decodeByteArray(byte[] data, int offset, int length, int re
}
}

private static void rewindStream(InputStream is) {
try {
is.reset();
} catch ( IOException e1 ) {
e1.printStackTrace();
}
}

public static Bitmap decodeResourceStream(Resources res, TypedValue value, InputStream is, Rect pad) {
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeResourceStream(res, value, is, pad, options);
rewindStream(is);
options.inSampleSize = 1;
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -191,6 +201,7 @@ public static Bitmap decodeResourceStream(Resources res, TypedValue value, Input
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeResourceStream(res, value, is, pad, options);
}
}
Expand All @@ -199,6 +210,7 @@ public static Bitmap decodeResourceStream(Resources res, TypedValue value, Input
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeResourceStream(res, value, is, pad, options);
rewindStream(is);
options.inSampleSize = Util.calculateInSampleSize(options, reqWidth, reqHeight);
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -214,6 +226,7 @@ public static Bitmap decodeResourceStream(Resources res, TypedValue value, Input
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeResourceStream(res, value, is, pad, options);
}
}
Expand All @@ -222,6 +235,7 @@ public static Bitmap decodeStream(InputStream is) {
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeStream(is, null, options);
rewindStream(is);
options.inSampleSize = 1;
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -237,6 +251,7 @@ public static Bitmap decodeStream(InputStream is) {
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeStream(is, null, options);
}
}
Expand All @@ -245,6 +260,7 @@ public static Bitmap decodeStream(InputStream is, int reqWidth, int reqHeight) {
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeStream(is, null, options);
rewindStream(is);
options.inSampleSize = Util.calculateInSampleSize(options, reqWidth, reqHeight);
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -260,6 +276,7 @@ public static Bitmap decodeStream(InputStream is, int reqWidth, int reqHeight) {
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeStream(is, null, options);
}
}
Expand All @@ -268,6 +285,7 @@ public static Bitmap decodeStream(InputStream is, Rect outPadding) {
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeStream(is, outPadding, options);
rewindStream(is);
options.inSampleSize = 1;
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -283,6 +301,7 @@ public static Bitmap decodeStream(InputStream is, Rect outPadding) {
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeStream(is, outPadding, options);
}
}
Expand All @@ -291,6 +310,7 @@ public static Bitmap decodeStream(InputStream is, Rect outPadding, int reqWidth,
final BitmapFactory.Options options = new BitmapFactory.Options();
options.inJustDecodeBounds = true;
BitmapFactory.decodeStream(is, outPadding, options);
rewindStream(is);
options.inSampleSize = Util.calculateInSampleSize(options, reqWidth, reqHeight);
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inMutable = true;
Expand All @@ -306,6 +326,7 @@ public static Bitmap decodeStream(InputStream is, Rect outPadding, int reqWidth,
if (Build.VERSION.SDK_INT > Build.VERSION_CODES.HONEYCOMB) {
options.inBitmap = null;
}
rewindStream(is);
return BitmapFactory.decodeStream(is, outPadding, options);
}
}
Expand Down