-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added full country name to short link stats #36
Conversation
@Whoami38 Thanks for the PR :) |
pygmyui/pygmy/views.py
Outdated
clickmeta['referrer'] = sorted( | ||
clickmeta['referrer'].items(), | ||
key=operator.itemgetter(1), | ||
reverse=True) | ||
|
||
refs = [(country,iso2full.get(country,"unknown"),hits) for (country, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Whoami38 this part is not required as clickmeta['referrer']
contains referrer info like [('https://google.com', 7), ('https://gmail.com', 3)]
where index 0 is the referral source and index 1 is the referral counts.
Check the referrer section here https://pygy.co/pygmy+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amitt001 Sorry for misunderstanding, i have changed this part in view file, as well as, in the template.
@Whoami38 Just tested and it looks good. I will rebase and merge it on the weekend. It's a nice improvement in the app. Thanks for your contribution 🙂 Have a look at other issues also and see if anything interests you |
Changes are now live on the website |
As you say in #34, i added a dict that contain full names of countries and changed template and view, so it shows full name of country with the code of country.