Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added full country name to short link stats #36

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Added full country name to short link stats #36

merged 2 commits into from
Jun 17, 2019

Conversation

hamidaskarov
Copy link
Contributor

@hamidaskarov hamidaskarov commented Jun 9, 2019

As you say in #34, i added a dict that contain full names of countries and changed template and view, so it shows full name of country with the code of country.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.09% when pulling 3b0fe83 on whoami38:add-country-full-name into 91572f9 on amitt001:master.

@amitt001
Copy link
Owner

@Whoami38 Thanks for the PR :)
Can you share the source of "iso2full.py" data, please?
The changes look good. I will review/merge it in the evening today.

@hamidaskarov
Copy link
Contributor Author

clickmeta['referrer'] = sorted(
clickmeta['referrer'].items(),
key=operator.itemgetter(1),
reverse=True)

refs = [(country,iso2full.get(country,"unknown"),hits) for (country,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Whoami38 this part is not required as clickmeta['referrer'] contains referrer info like [('https://google.com', 7), ('https://gmail.com', 3)] where index 0 is the referral source and index 1 is the referral counts.

Check the referrer section here https://pygy.co/pygmy+

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitt001 Sorry for misunderstanding, i have changed this part in view file, as well as, in the template.

Repository owner deleted a comment from coveralls Jun 12, 2019
@amitt001
Copy link
Owner

amitt001 commented Jun 14, 2019

@Whoami38 Just tested and it looks good. I will rebase and merge it on the weekend.

It's a nice improvement in the app. Thanks for your contribution 🙂 Have a look at other issues also and see if anything interests you

@amitt001 amitt001 merged commit 7d3df46 into amitt001:master Jun 17, 2019
@amitt001
Copy link
Owner

Changes are now live on the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants