New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions for groups can not be revoked w/o complete reset #267
Comments
As we found out, this is the intended behaviour in eve A possible solution would be to change the type for This would then look like this:
|
I think the behavior of eve is really weird in this case, it's a bit inconsistent. Maybe we should submit a pull request to allow disabling this behavior in the config. |
If you look at the response from nicolai to the issue, I don't see much hope for this to be patched in eve, his philosophy seems to be that overwrites should use PUT. |
I have created a pull request, lets see what the response will be! |
My pull request has been accepted. In the next release of Eve (0.8), we'll be able to disable this behavior in Eve. |
Eve 0.8 was released, that did not take long :)
…On Mon, May 7, 2018, 09:43 Alexander Dietmüller ***@***.***> wrote:
My pull request has been accepted. In the next release of Eve (0.8), we'll
be able to disable this behavior in Eve.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACsKUlf2hvIvNa2q7S9SkLIfKRBMoVYhks5tv_s8gaJpZM4TyqtN>
.
|
In it's default configuration, Eve merges nested documents on PATCH, and therefore using PATCH, it is impossible to delete keys from nested documents, e.g. it is not possible to remove single permissions from groups. We patched Eve to allow turning this feature off. With the switch to Eve 0.8, this feature is included in Eve and so this patch can turn off merging of nested documents. To make sure it's working, a test is added. Resolves #267.
In it's default configuration, Eve merges nested documents on PATCH, and therefore using PATCH, it is impossible to delete keys from nested documents, e.g. it is not possible to remove single permissions from groups. We patched Eve to allow turning this feature off. With the switch to Eve 0.8, this feature is included in Eve and so this patch can turn off merging of nested documents. To make sure it's working, a test is added. Resolves #267.
Original permission of a given group
The PATCH request to change a group's permissions with
results in
In order to revoke any permissions completely for a given group, first we have to patch the
permissions
field withnull
before we can patch the resource with the desired permissions.The text was updated successfully, but these errors were encountered: