Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cmlab link with github link (original i3d repo) #40

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Replace cmlab link with github link (original i3d repo) #40

merged 1 commit into from
Nov 19, 2020

Conversation

Nash2325138
Copy link
Collaborator

@Nash2325138 Nash2325138 commented Nov 1, 2020 •
edited
Loading

Why do we need this PR?

  • To fix the inaccessible link of i3d weight file (replace the cmlab one with the github one) (I did not realize the github raw link can be used, my bad)

PR readiness check list

  • Did it pass the Flake8 check?
  • Did you test this PR?

amjltc295
amjltc295 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Owner

@amjltc295 amjltc295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amjltc295 amjltc295 merged commit 19bfc6f into master Nov 19, 2020
@amjltc295 amjltc295 deleted the fix_inaccessible_link branch November 19, 2020 23:30
@amjltc295 amjltc295 mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amjltc295 amjltc295 amjltc295 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nash2325138 @amjltc295