Skip to content

Commit

Permalink
V0.9.4.2 (#93)
Browse files Browse the repository at this point in the history
* fix: fix bug in generate variant page (#79)

* fix: remove unused code used for debugging (#80)

* fix: gen variant page issue (#82)

* Revert "fix: gen variant page issue (#82)" (#83)

This reverts commit 649551c.

* fix: removed the logic from middleware and added directly in page (#84)

* Revert 81 master (#85)

* v0.9.1 (#76)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* v0.9.2 (#78)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 0.9.3 (#81)

* minor fix (#75)

* minor fix

* fix

* Bump undici and firebase (#74)

Bumps [undici](https://github.com/nodejs/undici) to 5.28.3 and updates ancestor dependency [firebase](https://github.com/firebase/firebase-js-sdk). These dependencies need to be updated together.


Updates `undici` from 5.26.5 to 5.28.3
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v5.26.5...v5.28.3)

Updates `firebase` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/firebase/firebase-js-sdk/releases)
- [Changelog](https://github.com/firebase/firebase-js-sdk/blob/master/CHANGELOG.md)
- [Commits](https://github.com/firebase/firebase-js-sdk/compare/firebase@10.8.0...firebase@10.8.1)

---
updated-dependencies:
- dependency-name: undici
  dependency-type: indirect
- dependency-name: firebase
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Amlan Roy <59330872+amlan-roy@users.noreply.github.com>

* fix: fix bug in generate variant page (#79)

* fix: remove unused code used for debugging (#80)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "0.9.3 (#81)"

This reverts commit dda048f.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "Revert 81 master (#85)" (#86)

This reverts commit 984f940.

* updated snapshots (#88)

* debug: refresh instead of push (#89)

Not sure if this will fix the issue of not navigating to the home page on successful login. Not able to test this here, so will have to test in prod (YOLO)

* Fix login issue (#92)

* fix: nav issue in home page variant button

* use refresh instead of push

* doc: added comments

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
amlan-roy and dependabot[bot] committed Mar 3, 2024
1 parent ed3aed9 commit e6f887c
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 7 deletions.
11 changes: 6 additions & 5 deletions src/app/(home-page)/home/page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
import { Button } from "@/components/ui/button";
import Link from "next/link";
import React from "react";
import { redirect } from "next/navigation";
import { useRouter } from "next/navigation";

type pageProps = {};
type PageProps = {};

const page: React.FC<pageProps> = () => {
const Page: React.FC<PageProps> = () => {
const router = useRouter();
return (
<>
<section className="max-w-screen-xl overflow-hidden px-4 sm:px-6 mt-10 mx-auto mb-28">
Expand Down Expand Up @@ -35,7 +36,7 @@ const page: React.FC<pageProps> = () => {
onClick={(e) => {
e.preventDefault();
const randomFormId = fetchRandomId(8);
redirect(`/generate-resume/${randomFormId}`);
router.push(`/generate-resume/${randomFormId}`);
}}
>
Generate Variant
Expand Down Expand Up @@ -65,4 +66,4 @@ function fetchRandomId(additionalLength: number) {
return id;
}

export default page;
export default Page;
4 changes: 3 additions & 1 deletion src/components/auth/GoogleJoinButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ const GoogleJoinButton: React.FC<GoogleJoinButtonProps> = ({
name: res.user.displayName,
email: res.user.email,
}));
router.push("/home");
// Not using router.push("/home") due to a cookie issue in prod environment
// Refer: https://github.com/amlan-roy/resume-craft/issues/91 for more context
router.refresh();
}
return;
}
Expand Down
2 changes: 2 additions & 0 deletions src/components/auth/login/LoginForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ const LoginForm: React.FC<LoginFormProps> = ({ hideForm }) => {
);

if (response.status === 200) {
// Not using router.push("/home") due to a cookie issue in prod environment
// Refer: https://github.com/amlan-roy/resume-craft/issues/91 for more context
router.refresh();
setLoginInProgress(false);
return;
Expand Down
4 changes: 3 additions & 1 deletion src/components/auth/signup/SignupForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ const SignupForm: React.FC<SignupFormProps> = ({ hideForm }) => {
);

if (response.status === 200) {
router.push("/home");
// Not using router.push("/home") due to a cookie issue in prod environment
// Refer: https://github.com/amlan-roy/resume-craft/issues/91 for more context
router.refresh();
return;
}
}
Expand Down

1 comment on commit e6f887c

@vercel
Copy link

@vercel vercel bot commented on e6f887c Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.