Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid parse of /foo(?#)bar/ #11

Closed
backus opened this issue Apr 18, 2016 · 0 comments
Closed

Invalid parse of /foo(?#)bar/ #11

backus opened this issue Apr 18, 2016 · 0 comments

Comments

@backus
Copy link
Contributor

backus commented Apr 18, 2016

It looks like the edge case /foo(?#)bar/ is not properly parsed. I found this while running this gem against rubyspec. Here is the relevant part of the spec: https://github.com/ruby/spec/blob/master/language/regexp_spec.rb#L102-L105
@backus backus mentioned this issue Apr 18, 2016
Merged
backus added a commit to backus/regexp_parser that referenced this issue Apr 19, 2016
@backus
Fix lexing for zero length group comment /(?#)/
a8b754a 
Fixes ammar#11
@backus backus mentioned this issue Apr 19, 2016
Merged
backus added a commit to backus/regexp_parser that referenced this issue Apr 19, 2016
@backus
Fix lexing for zero length group comment /(?#)/
5b4f6d2 
Fixes ammar#11
@ammar ammar closed this as completed in 5370964 Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@backus