Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we have multiple instance of ads inside flat list ? #56

Closed
paddy57 opened this issue Jul 28, 2020 · 5 comments
Closed

Can we have multiple instance of ads inside flat list ? #56

paddy57 opened this issue Jul 28, 2020 · 5 comments

Comments

@paddy57
Copy link

paddy57 commented Jul 28, 2020

I have a flat list, where I'm rendering three instance of ads on current, previous, and next items of a flat list.
Which is making my flatlist performance slow.
Is it ideal to have multiple instances of ads in list?

@Jean-Kenned
Copy link

Jean-Kenned commented Jul 31, 2020

I 'm having the same problem now, I have been tried to follow tips about FlatList performance like setting windowSize, maxToRenderPerBatch and removeClippedSubViews props, but the performance in FlatList is still slow. Furthermore, I already tried to use all the solution mentioned in facebook/react-native#13413 but anything works effectively in this case. In fact, I noticed that decreasing the frequency that ads are shown increase the performance, but it is not an option for me. Any help?

@cristea2017
Copy link

cristea2017 commented Aug 4, 2020

you should try https://github.com/Flipkart/recyclerlistview
with this you can use multiple ads 100%

@samuely4ng
Copy link

@cristea2017 +1 to that. In general you shouldn't use FlatList (for anything) if recyclerlistview is an option.

@ammarahm-ed
Copy link
Owner

ammarahm-ed commented Aug 12, 2020

@paddy57 @Jean-Kenned There must be something you are doing that is causing that, I have tested the ads in a FlatList by loading more than 100 ads at once and I saw no frame drops. It was working perfectly, make sure you are on the latest version of this library when you test. Also you can try this in the example app inside this library. However I will test this again. @cristea2017 +1 to that too.

@ammarahm-ed
Copy link
Owner

ammarahm-ed commented Aug 21, 2020

This has been fixed. Try the latest release, v0.3.6 @paddy57 @Jean-Kenned @cristea2017 @samuely4ng try the example in the project. Now i have added full example for all use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants