-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Ad repository feature #216
Conversation
…admob-native-ads * 'master' of https://github.com/ammarahm-ed/react-native-admob-native-ads: (190 commits) fix typo update version to 0.5.0 update version to 0.4.2 minor update in docs update example remove duplicate declaration use videoController provided by events in MediaView fix paused prop not passed correctly render button properly on ios in example fix multiple ad loading on ios ui update in example app update google ads sdk on android to latest. remove jcenter from build.gradle update dependencies Simplify ios imports and fb mediation as option chore: format index.d.ts fix example ios app crash add migrating from 0.4.1 update docs update example app ...
* master: fix typo update version to 0.5.0 update version to 0.4.2 minor update in docs update example remove duplicate declaration use videoController provided by events in MediaView fix paused prop not passed correctly render button properly on ios in example fix multiple ad loading on ios ui update in example app update google ads sdk on android to latest. remove jcenter from build.gradle # Conflicts: # android/build.gradle # android/src/main/java/com/ammarahmed/rnadmob/nativeads/RNAdmobNativeView.java # example/ios/Podfile # example/ios/Podfile.lock # ios/RNAdMobManager/RNGADNativeView.m
Hello by ad repository, you mean to preload ads so they are shown immediately when the view mounts? This has been a long awaited feature. Thanks for all the work. It appears that you continued working on an older pull request #94. How is the implementation different and what have you changed/improved. Also can you explain how this works and what breaking changes does it include? |
Hi, Ammarahm.
If you have more questions, don't hesitate to ask. |
@Ali72 Thanks for the detailed explanation. I really appreciate you working on such an important feature. The question I have is, what happens to the ad after it has been shown and the view gets destroyed? The ad repository code lacks the fine grain control over ads as we do through Lastly what is the purpose of |
@ammarahm-ed we will add new ads repositories options such as mediation options, video options, targeting options, etc soon. Note : base of this link, if you request more than 5 ads for a repository, AdMob will reduce it to 5, therefore, the ad repository should divide it into multi requests so when finished first request loading it will send the same request to get the rest of the ads to fill up the repository. Best regard, Ali |
@Ali72 Okay sounds good. I am working on refactoring the android code. So I will add these options on android and hopefully ios too. |
Add Ads repository
description:
ads automatically load and keep in the repository and display it immunity when showing native ad view. if the developer declares repositories, he can load ads from the repos instead of a request to the server.
features: